fix: reject duplicate initialize requests#962
Open
he-yufeng wants to merge 2 commits into
Open
Conversation
he-yufeng
force-pushed
the
fix/reject-duplicate-initialize
branch
from
603d55c to
f62a410
Compare
| }) | ||
| if duplicate { | ||
| ss.server.opts.Logger.Error("duplicate initialize request") | ||
| return nil, fmt.Errorf("%w: duplicate %q received", jsonrpc2.ErrInvalidRequest, methodInitialize) |
Contributor
There was a problem hiding this comment.
// ErrInvalidRequest is used when the JSON sent is not a valid Request object.
This does not seem the right error for this case. We might align it to the 'duplicate initialized notification' case error
he-yufeng
force-pushed
the
fix/reject-duplicate-initialize
branch
from
f62a410 to
64d6f95
Compare
Author
|
Thanks, that makes sense. I pushed Validation run locally:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initializerequest on an already initialized server sessionServerSession.InitializeParams()instead of replacing it with later client parametersFixes #961.
To verify
go test ./mcp -run TestServerRejectsDuplicateInitialize -count=1go test ./mcp -count=1go test ./...